Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fillNodes overwrites the layout and children properties #62

Closed
esprehn opened this issue Mar 26, 2015 · 1 comment · Fixed by #108
Closed

fillNodes overwrites the layout and children properties #62

esprehn opened this issue Mar 26, 2015 · 1 comment · Fixed by #108

Comments

@esprehn
Copy link

esprehn commented Mar 26, 2015

If node already has a layout object it should leave it alone, this just means allocating new Rect like objects each time this is called even if layout has been done before.

Also if you define node.style.measure it clears the children property, but that's bad if the measure function wanted to be able to look at the children or call layout on them.

@vjeux
Copy link
Contributor

vjeux commented Jun 4, 2015

Please feel free to send a pull request for this :) The js version has not been designed with performance in mind, only the C one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants