-
Notifications
You must be signed in to change notification settings - Fork 2.1k
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Warning with -Wunused-return on gcc #4133
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When building with
-std=c++17
and-Wunused-return
, gcc issues a warning.I noticed this when building the Arch Linux build, but I reproduced it when building the
dev
branch as well.I read the note about static analysis in the contribution guidelines. Using something like
std::ignore
would clarify that the return value here is irrelevant.To Reproduce
Steps to reproduce the behavior (with
make
):cd contrib/pzstd
PZSTD_CXX_STD
inMakefile
export CPPFLAGS="-Wunused-result"
export CXXFLAGS="-std=c++17"
make
Expected behavior
There should be no compiler warnings when building.
Screenshots and charts
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: