Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

remove React and ReactDOM from devDependencies #951

Closed
FourwingsY opened this issue Jan 17, 2017 · 3 comments
Closed

remove React and ReactDOM from devDependencies #951

FourwingsY opened this issue Jan 17, 2017 · 3 comments
Labels
needs more info

Comments

@FourwingsY
Copy link

peerDependencies contains react and react-dom.
When react and react-dom are both declared in devDependencies and peerDependencies, Yarn will install them in it's own node_modules. It makes error #296
@apuntovanini
Copy link

Is it facebook/react#8026 ?

@hellendag
Copy link

Not able to repro this with a fresh project and yarn adding draft-js, react, and react-dom. My node_modules dir looks correct.

@flarnie
Copy link
Contributor

flarnie commented Jun 26, 2017

It looks like this is no longer repro'ing - closing but please reopen or open a new issue if this is still a problem.

@flarnie flarnie closed this as completed Jun 26, 2017
@flarnie flarnie mentioned this issue Jun 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flarnie @apuntovanini @hellendag @FourwingsY