Improve ambiguous logIn() function names in LoginManager.

[nitisha1]

Hi,
I've integrated facebook-sdk-swift manually in my ios project in xcode8 following documents (https://developers.facebook.com/docs/swift/getting-started). I'm getting error "Ambiguous reference to memeber logIn(_:viewController:completion:)"on

loginManager.logIn(["public_profile","email"], viewController: self) { loginResult in switch loginResult { case .Failed(let error): print(error) case .Cancelled: print("User cancelled login.") case .Success(let grantedPermissions, let declinedPermissions, let accessToken): print("Logged in!") }
what i've done wrong any help please?

[nlutsenko]

Hey @nitisha1,

Unfortunately, without more code around this - it could be very tricky to help you.
Though, I believe I have an idea on why this is failing...
Looks like you are using plain strings for permissions, which can be ambiguous, as the Swift compiler won't know whether to use

func logIn(_ permissions: [ReadPermission] = [.publicProfile],
                    viewController: UIViewController? = nil,
                    completion: ((LoginResult) -> Void)? = nil)

or

func logIn(_ permissions: [PublishPermission] = [.publishActions],
                    viewController: UIViewController? = nil,
                    completion: ((LoginResult) -> Void)? = nil)

Here is the updated method signature that I recommend replacing it with:

loginManager.logIn([ .public_profile, .email ], viewController: self) {
...
}

This will eliminate the ambiguousness and will let you compile.
Also, let me keep this open as a follow-up, since I believe we can improve these method names.

[nitisha1]

@nlutsenko thanks a lot ,it worked.

[flavian-iapp]

don't work for me

[bj97301]

I am not using strings and still getting this error.

[JaapWeijland]

Me too.

[krishcdbry]

Me too