Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Feature Request: Option for nuclide terminal colors to be derived from syntax theme #1560

Open
afridley opened this issue Jun 21, 2018 · 3 comments

Comments

@afridley
Copy link

Issue and Steps to Reproduce

It would be wonderful to see an option to have terminal syntax colors match the syntax theme being applied.

Expected Behavior

When syntax theme is switched. Terminal syntax colors change to match the newly applied theme

Actual Behavior

colors stay as what is defined in the nuclide terminal settings

Versions

  • Atom: 1.25.1
  • Nuclide: 0.299.0
  • Client OS: mac
  • Server OS (optional):
@slnt
Copy link

slnt commented Sep 17, 2018

Why this isn't already built it, who knows :/

@pelmers
Copy link
Contributor

pelmers commented Sep 17, 2018

Mentioned in facebookarchive/atom-ide-ui#308, but it's fairly simple to script the color selection.

However deriving the colors from syntax theme in a general way is prone to inconsistencies because not every package defines the same colors. Our full list is in https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-terminal/package.json#L140-L235.

@slnt
Copy link

slnt commented Sep 21, 2018

@pelmers what about a tool built in that would import colors from terminal files for some popular terminals?

For example, for people that use iTerm outside of Atom, loading from a *.itermcolors file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants