Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Should activateSpring be activateSpringById #24

Open
appsforartists opened this issue Jan 5, 2017 · 1 comment
Open

Should activateSpring be activateSpringById #24

appsforartists opened this issue Jan 5, 2017 · 1 comment

Comments

@appsforartists
Copy link
Contributor

Methods like registerSpring and deregisterSpring take a Spring instance; whereas, getSpringById takes a number. If activateSpring takes a number, perhaps it should be called activateSpringById.
@wbinnssmith
Copy link
Contributor

hi @appsforartists! I completely agree. Let's definitely do this when we make an api-breaking major version bump :)

@wbinnssmith wbinnssmith mentioned this issue Feb 26, 2018
Open
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wbinnssmith @appsforartists