Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request_stop() return value is invalid #585

Open
nuttert opened this issue Nov 13, 2023 · 0 comments
Open

request_stop() return value is invalid #585

nuttert opened this issue Nov 13, 2023 · 0 comments

Comments

@nuttert
Copy link

nuttert commented Nov 13, 2023

request_stop() method in stop_source should return

true if the stop_source object has a stop-state and this invocation made a stop request, otherwise false.

But your method returns false in case of successful request for the invocation.

The same logic I see in the NVIDIA project

P.S. Also why did you skip unlock()? Is it really safe for 2 threads that make the stop_request ?
@nuttert nuttert changed the title request_stop() result is invalid request_stop() return value is invalid Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nuttert