Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #127 #128

Merged
merged 1 commit into from
Jul 23, 2016
Merged

Fix issue #127 #128

merged 1 commit into from
Jul 23, 2016

Conversation

JWo1F
Copy link

@JWo1F JWo1F commented Jul 23, 2016 •
edited
Loading

No description provided.

@ghost
Copy link

ghost commented Jul 23, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Jul 23, 2016
@ghost
Copy link

ghost commented Jul 23, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mxstbr
Copy link
Contributor

mxstbr commented Jul 23, 2016

This looks perfect from a code perspective, thanks @JWo1F! Let's wait for @gaearon to merge this.

@ghost ghost added the CLA Signed label Jul 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

Does WDS auto refresh or CSS hot reloading still work after this? We are hardcoding localhost in dev Webpack config, would this break it?

@mxstbr mxstbr mentioned this pull request Jul 23, 2016
Closed
@mxstbr
Copy link
Contributor

mxstbr commented Jul 23, 2016

I don't actually know! Would you mind trying those @JWo1F?

@ghost ghost added the CLA Signed label Jul 23, 2016
@mxstbr
Copy link
Contributor

mxstbr commented Jul 23, 2016

I just tried it, both still work @gaearon! This seems to be good to go, doesn't break anything for me.

@ghost ghost added the CLA Signed label Jul 23, 2016
@gaearon gaearon merged commit c9fd697 into facebook:master Jul 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 23, 2016

Great, thanks for sending the PR!

@gaearon gaearon mentioned this pull request Jul 24, 2016
Closed
@gaearon gaearon added this to the 0.2.0 milestone Jul 25, 2016
@gaearon gaearon mentioned this pull request Jul 27, 2016
Merged
@andriijas andriijas mentioned this pull request Mar 13, 2018
Merged
23 tasks
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JWo1F @mxstbr @gaearon