Fix crash when type param has an annotation #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
cgrushko
reviewed
Feb 11, 2022
| @@ -1939,21 +1939,7 @@ class KotlinInputAstVisitor( | |||
|
|
|||
| override fun visitTypeParameter(parameter: KtTypeParameter) { | |||
| builder.sync(parameter) | |||
| if (parameter.hasModifier(KtTokens.REIFIED_KEYWORD)) { | |||
There was a problem hiding this comment.
ha, that's nice, that we can delete all of this
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nreid260
force-pushed
the
type_param_anno
branch
from
ef5a6ee
to
ed686ce
Compare
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@cgrushko has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nreid260
added a commit
to nreid260/ktfmt
that referenced
this pull request
Feb 13, 2022
Summary: Pull Request resolved: facebook#281 Reviewed By: strulovich Differential Revision: D34167891 Pulled By: cgrushko fbshipit-source-id: 16b32efd388f895fc69e445cc15f37287c42f905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.