Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with -threaded #17

Open
pepeiborra opened this issue Aug 15, 2020 · 1 comment
Open

Build with -threaded #17

pepeiborra opened this issue Aug 15, 2020 · 1 comment

Comments

@pepeiborra
Copy link
Contributor

Otherwise there is no parallelism.
Perhaps consider using setNumCapabilities too.

@xich
Copy link
Contributor

xich commented Aug 17, 2020

I would totally support this change, but I don't have bandwidth to do it myself right now.

I tried this once (years ago) and had issues with the GHC API crashing. I don't think the GHC session is (or was?) thread safe, or at least not the way retrie uses it (probably the actual problem).

We still get IO concurrency, which is a pretty big win. I suspect most of the time is spent parsing files, but don't have numbers to back that up. (You can run retrie with --single-threaded and see that it is quite a bit slower.) Maybe some sort of benchmark suite with criterion is a good first step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants