-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feasibility of using retrie to refactor for Data.List monomorphisation #26
Comments
I think it depends on how automated you want this to be. If the end user is willing to do a little work themselves, then you could do something like:
(it would be faster if we did all the rewrites at once by building something with But that will rewrite any instance of If you want this it be fully automatic, we'd need to solve #10 first and probably build this into/with haskell-language-server (so we have a source of renamed identifiers) cc @pepeiborra. (And also add import deletion/modification, but that is easy.) What's your timeline? I think I have a handle on how to tackle #10, but am traveling the first couple weeks of July, so not sure how soon I could have something ready. |
/cc @OliverMadine who was also looking at a closer integration of retrie with HLS |
Thanks @xich! This isn't urgent but the sooner it can be done the sooner users migrating to 9.2 can benefit. |
Please note that it is actually 9.4 - however, the change is going to be reverted and postponed until at least 9.6, possibly later. If retrie could come to handle this change in the meantime, that would greatly benefit the haskell community at large. |
9.4 is about to be released, I think it's a good time to get things going on that front. :) |
In GHC 9.2
Data.List
is changing with the expectation that all imports be qualified (or, at very least, bearing an explicit import list). Specifically, we would need to change all occurrences of declarations defined inData.List
to a module prefixed name (e.g.L.map
) and change all imports toqualified
imports.As this will be a somewhat invasive change, it would be great to be able to offer a
retrie
recipe in the GHC 9.2 migration guide. Is this feasible?The text was updated successfully, but these errors were encountered: