Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of State Transition Dataset Wrapper #678

Closed
vladaindjic opened this issue May 12, 2022 · 3 comments · Fixed by #679
Closed

Implementation of State Transition Dataset Wrapper #678

vladaindjic opened this issue May 12, 2022 · 3 comments · Fixed by #679
Assignees
Labels
Question Further information is requested

Comments

@vladaindjic
Copy link

❓ Questions and Help

Hi, @ChrisCummins ,

Sorry to interrupt. While reading the CompilerGym paper, I encountered on the State Transition Dataset Wrapper "that asynchronously populates the Steps and Observations tables of a state transition database upon every step of an environment." The populated dataset is then used for offline training. Unfortunately, I could not find the implementation of the wrapper inside this repository. Could you please guide me to the place where I could find the implementation of this wrapper?

Thanks in advance.

Kind regards,
Vladimir

Additional Context

@vladaindjic vladaindjic added the Question Further information is requested label May 12, 2022
@ChrisCummins
Copy link
Contributor

Hey @vladaindjic, good question. I haven't get got around to open sourcing it. Let me copy over the version from my internal repo now

@ChrisCummins
Copy link
Contributor

Okay, I filed #679. It's the wrapper I used to generate the dataset we released, and isn't super extensible. If you want to change what is recorded, you would need to hack on the source. One caveat - this is a synchronous implementation - so the overhead of storing entries is added to compiler interactions. The async implementation still needs more work and tweaking.

Cheers,
Chris

@vladaindjic
Copy link
Author

Hi, @ChrisCummins ,

Thanks a lot for your prompt response. :) No problem if some hack needs to be applied in order to adapt the wrapper.

Cheers,
Vladimir

@ChrisCummins ChrisCummins self-assigned this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Question Further information is requested
Projects
None yet
2 participants