Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all bazel tests in CI? #693

Open
mostafaelhoushi opened this issue May 30, 2022 · 2 comments
Open

Run all bazel tests in CI? #693

mostafaelhoushi opened this issue May 30, 2022 · 2 comments
Assignees

Comments

@mostafaelhoushi
Copy link
Contributor

Can we add to the CI:

  • bazel test //examples/... to run all bazel tests in the examples directory
  • or even bazel test ... to run all bazel tests in the repo
@mostafaelhoushi mostafaelhoushi self-assigned this May 30, 2022
@mostafaelhoushi
Copy link
Contributor Author

@ChrisCummins can we do that? Do you know where in the ci.yaml file or Makefile we can add the bazel test command?

This will make it easier to enable example tests in CI.... then in the future we can enable examples tests without bazel in CI

@ChrisCummins
Copy link
Contributor

@ChrisCummins can we do that? Do you know where in the ci.yaml file or Makefile we can add the bazel test command?

Yes, it is totally do-able. I removed bazel test jobs in #392. It would be worth reading through the PR message and #385 for the rationale.

Would it be possible to use the build-linux-cmake job to compile any missing C++ tests for execution by cmake? I see that we compile with COMPILER_GYM_BUILD_TESTS=ON, but then don't actually use them.

Cheers,
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants