-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add support for presaved options (options aliases) #3416
Comments
Should this Also would be cool if there was an auto test for these options files that checked that the options were parsed correctly (so that when you add new options files you can be sure that the implementation didn't miss anything) |
Let's just make sure we can support folders there, and let the structure evolve over time? I'm really not sure what the right tradeoff of flat namespace vs proper hierarchy is. With a certain level of hierarchy, I would say the advantage of the shorthands are pretty much lost... |
i'd propose only file structure; on the command line, you would still be able to specify as i type this i realize that might obfuscate what's available. If we do not enforce file structure, then should we at least enforce options name structure? so all generation params must start |
I'd really rather have a 1:1 mapping between the folder and the utterance. so like Let's set naming conventions in parley. |
This issue has not had activity in 30 days. Please feel free to reopen if you have more issues. You may apply the "never-stale" tag to prevent this from happening. |
This landed with #3564 so i think we can close |
We already support for setting options from the command line.
Set up here:
ParlAI/parlai/core/params.py
Lines 648 to 654 in c2c800e
This is handled here:
ParlAI/parlai/core/params.py
Line 974 in c2c800e
We would like to be able to distribute options files with parlai.
_load_known_opts
so that when a user specifies "-o whatever" it looks inside parlai/options/whatever.opt to see if it can load options from there. Only do this if it is not a literal filename_load_known_opts
so that if there is a comma, it splits it and performs the load multiple times in sequence (-o presaved1,presaved2
should load presaved1.opt and then presaved2.optgenerate_options.py
inside docs, to generate a page which enumerates all the files in parlai/options and explicitly spells out what they are shorthand for. Put this as a new section inside "Scripts & CLI" called "Options shorthands" or similarAdditionally, please create a few initial options files for people to draw inspiration from:
--beam-size 10 --inference beam --beam-block-ngram 3 --beam-context-block-ngram 3 --beam-min-length 20
--inference topk --beam-size 20 --topk 40
The text was updated successfully, but these errors were encountered: