This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[Tests bug] Tests exposes incorrect behavior of warmup scheduling #4243

Closed

DrMatters opened this issue Dec 10, 2021 · 0 comments

Contributor

DrMatters commented Dec 10, 2021 •

edited

Loading

Fixing the clearly wrong parameter name in testbench (#4242) exposed that warmup schedulers are behaving incorrectly.

It seems to me that the def step method here of ParlAILRScheduler stops to warm up the learning rate too early.

I think it might be easier and less error-prone to use SequentialLR scheduler instead of custom ParlAILRScheduler.

The text was updated successfully, but these errors were encountered:

DrMatters mentioned this issue

Fix "Warmup scheduler is loaded from the state dict, even when initializing fresh" #4196

Merged

DrMatters closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.