Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering Support on Index Created using IndexIDMap #2843

Closed
navneet1v opened this issue May 2, 2023 · 4 comments
Closed

Filtering Support on Index Created using IndexIDMap #2843

navneet1v opened this issue May 2, 2023 · 4 comments

Comments

@navneet1v
Copy link

navneet1v commented May 2, 2023

Description

I am from OpenSearch Team. We are using Faiss Library C++ code to enable the K-NN search in OpenSearch via k-NN Plugin. At the bottom we create the faiss index and then do the search on those indices.

Question

Currently we have different types of indices(hnsw, IVF and IVF-PQ) we create based on customer parameters, and we want to support filtering using IDSelector on those indices. But currently when I tried to enable it I am getting exception which is coming from here.

Based on the above context I have few questions:

  1. Why filtering is not supported on indices created using: IndexIDMap?
  2. Is there any plan to support the filtering on indices created using IndexIDMap?
@mdouze
Copy link
Contributor

mdouze commented May 3, 2023

There is no particular reason other than the we did not have a use case for it so far.
I will implement this with a wrapped IDSelector that uses the id_map to translate indices.

@navneet1v
Copy link
Author

navneet1v commented May 3, 2023

@mdouze thanks this will be very useful. Any ETA that I can track for this change?

@vamshin
Copy link

vamshin commented May 4, 2023

@mdouze in the context of supporting pre filters on faiss indexes, this is very important feature for us. Any inputs on the timeline would be super helpful.

@navneet1v
Copy link
Author

navneet1v commented May 5, 2023

Thanks @mdouze for raising the PR.

I can see the PR here: #2848

cc: @vamshin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants