Implement METRIC.NaNEuclidean #3414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57017608 |
asadoughi
pushed a commit
that referenced
this pull request
May 6, 2024
Summary: #3355 A couple open questions: - Given L2 was squared, I figured I would leave this one as squared as well? - Also, wasn't sure if we wanted to return nan when present == 0 or -1? Differential Revision: D57017608
asadoughi
force-pushed
the
export-D57017608
branch
from
8fe159e
to
c28b2b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57017608 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 15, 2024
Summary: #3355 A couple open questions: - Given L2 was squared, I figured I would leave this one as squared as well? - Also, wasn't sure if we wanted to return nan when present == 0 or -1? Reviewed By: mdouze Differential Revision: D57017608
facebook-github-bot
force-pushed
the
export-D57017608
branch
from
c28b2b3
to
9f01ff3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57017608 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 15, 2024
Summary: #3355 A couple open questions: - Given L2 was squared, I figured I would leave this one as squared as well? - Also, wasn't sure if we wanted to return nan when present == 0 or -1? Reviewed By: mdouze Differential Revision: D57017608
facebook-github-bot
force-pushed
the
export-D57017608
branch
from
9f01ff3
to
c576dc7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57017608 |
Summary: #3355 A couple open questions: - Given L2 was squared, I figured I would leave this one as squared as well? - Also, wasn't sure if we wanted to return nan when present == 0 or -1? Reviewed By: mdouze Differential Revision: D57017608
asadoughi
force-pushed
the
export-D57017608
branch
from
c576dc7
to
b707d17
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57017608 |
|
This pull request has been merged in 1876925. |
abhinavdangeti
pushed a commit
to blevesearch/faiss
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: facebookresearch#3414 facebookresearch#3355 A couple open questions: - Given L2 was squared, I figured I would leave this one as squared as well? - Also, wasn't sure if we wanted to return nan when present == 0 or -1? Reviewed By: mdouze Differential Revision: D57017608 fbshipit-source-id: ba14458b92c8b055f3bf2a871565175935c8333a
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: Pull Request resolved: facebookresearch#3414 facebookresearch#3355 A couple open questions: - Given L2 was squared, I figured I would leave this one as squared as well? - Also, wasn't sure if we wanted to return nan when present == 0 or -1? Reviewed By: mdouze Differential Revision: D57017608 fbshipit-source-id: ba14458b92c8b055f3bf2a871565175935c8333a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#3355
A couple open questions:
Differential Revision: D57017608