Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic Sensor Issue in the latest main branch #2803 #2087

Closed
Jianghanxiao opened this issue Apr 29, 2023 · 1 comment · Fixed by #2090
Closed

Semantic Sensor Issue in the latest main branch #2803 #2087

Jianghanxiao opened this issue Apr 29, 2023 · 1 comment · Fixed by #2090
Assignees
@jturner65

Comments

@Jianghanxiao
Copy link

Jianghanxiao commented Apr 29, 2023 •
edited
Loading

Habitat-Sim version

main

🐛 Bug

The semantic sensor for FP dataset doesn't work. This is caused by the default value of flags_ in PbrDrawable. The judging here will always return True because the flags_ is initialized with that PbrShader::Flag::ObjectId. Here we should call this one to fix materialData_->attribute<bool>("hasPerVertexObjectId")

Steps to Reproduce

Any scene in FP will have the problem
This was referenced Apr 29, 2023
Open
Closed
@jturner65 jturner65 self-assigned this May 1, 2023
@jturner65
Copy link
Contributor

This PR should address this issue
#2090

@Skylion007 Skylion007 mentioned this issue May 1, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jturner65 jturner65

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

--Address inappropriate bitflag check; add vertexID flag to PBR shader facebookresearch/habitat-sim
2 participants
@jturner65 @Jianghanxiao