Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Obsolete typing.io import #2218

Closed
1 of 2 tasks
srittau opened this issue May 18, 2022 · 1 comment
Closed
1 of 2 tasks

[Bug] Obsolete typing.io import #2218

srittau opened this issue May 18, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@srittau
Copy link

srittau commented May 18, 2022

🐛 Bug

Description

hydra-core 1.2.0 contains two generated files with an obsolete import from typing.io import TextIO. The typing.io namespace has been deprecated since Python 3.8 and will be removed in Python 3.12. (Cf. python/cpython#92871) The imports can simply be replaced with from typing import TextIO:

  • hydra/grammar/gen/OverrideLexer.py
  • hydra/grammar/gen/OverrideParser.py

Checklist

  • I checked on the latest version of Hydra
  • I created a minimal repro (See this for tips).

System information

  • Hydra Version : 1.2.0
  • Python version :
  • Virtual environment type and version :
  • Operating system :
@srittau srittau added the bug Something isn't working label May 18, 2022
@srittau srittau changed the title [Bug] [Bug] Obsolete typing.io import May 18, 2022
@pixelb pixelb self-assigned this May 18, 2022
@pixelb
Copy link
Contributor

pixelb commented Oct 3, 2022

This was addressed implicitly by the upgrade of antlr from 4.8 to 4.9 (in issue #2155)
which guards the old use of typing.io with a python version check.

@pixelb pixelb closed this as completed Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants