-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Precompiled xFormers for CUDA 12.4 and PyTorch 2.4 Compatibility #1079
Comments
Hi,
|
I'm sorry, I corrected the description. |
Forge works on newer ones. |
Providing builds for multiple CUDA versions comes at a cost, which is why at the moment we only support two versions (11.8 and 12.1). Could you explain why you need CUDA 12.4 specifically and cannot use 12.1? I believe PyTorch plans to drop support for CUDA 11.8 shortly (pytorch/pytorch#123456), and when they do we will follow, and at that point we'll happily support newer versions of CUDA. |
illyasviel has globally updated Forge to work with a variety of image generation models. And now most people who have updated get the error "TypeError: 'NoneType' object is not iterable" until xformers is removed from the environment. illyasviel recommends the following:
But by default, when cloning the repository, CUDA 12.4 + Pytorch 2.4 is installed |
Vote for this request please i.e. to implement CUDA 12.4, Pytorch 2.4. I encountered same error in our recent projects. venv\Lib\site-packages\xformers\ops\fmha\dispatch.py", line 55, in _run_priority_list |
xFormers for CUDA 12.4 and PyTorch 2.4 needed. \ComfyUI_windows_portable\python_embeded\Lib\site-packages\xformers\ops\fmha\flash.py:210: FutureWarning: `torch.library.impl_abstract` was renamed to `torch.library.register_fake`. Please use that instead; we will remove `torch.library.impl_abstract` in a future version of PyTorch. |
Looks like the Xformers team just granted your wish ! https://github.com/facebookresearch/xformers/actions/runs/10559887009
|
How do I install that specific version? I cant find it at https://download.pytorch.org/whl/xformers/. |
It has a universal version if you install the latest build. |
Will precompiled xFormers be available for PyTorch 2.4.1? |
+1 |
I get |
Feature
A precompiled version of xFormers that is compatible with CUDA 12.4 and PyTorch 2.4 .
Motivation
Many users, including those working with projects like Forge, are now transitioning to newer versions of CUDA and PyTorch. However, the lack of precompiled xFormers binaries for CUDA 12.4 and PyTorch 2.4 creates a barrier for these users. Building from source is not always feasible, especially in restricted environments or for users who may not be comfortable with the complexities of manual builds.
Pitch
Providing a precompiled xFormers binary compatible with CUDA 12.4 and PyTorch 2.4 would simplify the installation process for a wide range of users. This would reduce the likelihood of build errors and allow users to focus on their core projects rather than troubleshooting build environments. It would also ensure better integration with projects like Forge, where xFormers is a key dependency.
Alternatives
Currently, the only alternative is to build xFormers from source, which can be time-consuming and error-prone, particularly for users unfamiliar with the process or those working in environments with limited permissions.
Additional Context
The availability of precompiled binaries would greatly benefit the community, especially as CUDA 12.4 and PyTorch 2.4 become more widely adopted. This request is in alignment with the needs of ongoing projects and would enhance the usability of xFormers in modern machine learning pipelines.
The text was updated successfully, but these errors were encountered: