Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-refresh support/replacement for react-hot-loader #212

Open
JustFly1984 opened this issue May 22, 2020 · 1 comment
Open

react-refresh support/replacement for react-hot-loader #212

JustFly1984 opened this issue May 22, 2020 · 1 comment

Comments

@JustFly1984
Copy link

I'm using react-universal-component in multiple gatsby.js projects. Current version of gatsby.js made switch from hot-reload to better supported by React react-refresh

I've updating the codebase, and stumble upon yarn install warning:

warning "react-universal-component > react-hot-loader@4.12.20" has unmet peer dependency "@types/react@^15.0.0 || ^16.0.0".

And I got curious if it react-hot-loader dependency of react-universal-component could break or conflict with react-refresh some way.

PS: I do not care much about @types/react missing peer dependency, as @types/react-dom has it as direct dependency.

@OliverJAsh
Copy link
Contributor

AFAICS react-hot-loader is not actually used in the source code, so I'm not sure why it's listed as a dependency. It was added in 3c21ffa#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants