fix(confirmLeave): update current route's history blocking after "addRoutes" #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing today, appreciate the PR! |
|
@ScriptedAlchemy, absolutely! Let me know how I can improve the PR. |
|
🎉 This PR is included in version 2.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
This PR introduces support of usage scenarios when initial route is needed to be location-blocking and loaded partially (without
confirmLeaveproperty) on init but it's updated (addingconfirmLeave) usingaddRoutes()later. It's necessary if the following conditions are combined:pathproperty);confirmLeave()is present on route's full config).We use this technique at fish.travel right now.
Also,
@oopscurity/redux-first-router@2.1.2includes these changes applied on the original repo'smasterbranch.