Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotjuggler crashes when trying to save color map script with syntax errors #687

Closed
Bartimaeus- opened this issue Jul 12, 2022 · 2 comments
Closed

Plotjuggler crashes when trying to save color map script with syntax errors #687

Bartimaeus- opened this issue Jul 12, 2022 · 2 comments

Comments

@Bartimaeus-
Copy link
Contributor

Trying to save a ColorMap with invalid lua script content causes Plotjuggler to crash in v3.5.0

Things like bad syntax or not returning a value will cause Plotjuggler to crash when attempting to save the color map
Example:
image

Perhaps adding the red/green dot check as done elsewhere would be a good fix
image

The color map feature is pretty great so far despite this issue, glad to see this feature
@facontidavide
Copy link
Owner

Is this happening in windows or Linux?

@Bartimaeus-
Copy link
Contributor Author

Windows 10. Have not tested on Linux
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@facontidavide @Bartimaeus-