Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS1 support? #8

Open
v4hn opened this issue Jun 26, 2024 · 1 comment
Open

ROS1 support? #8

v4hn opened this issue Jun 26, 2024 · 1 comment

Comments

@v4hn
Copy link

v4hn commented Jun 26, 2024

Hi @facontidavide ,

looks like you are moving forward with projects at your usual speed 👟 . You sure keep busy.

The README.md for the project states:

The library compiles either using:

ROS1 (catkin),
ROS2 (colcon/ament) or
without any ROS dependency (vanilla cmake).

But there is sadly no support for catkin yet.
Instead, the check for whether this is a ROS2 build is based on whether ament_cmake is installed on the system, which is true if you run ROS and ROS2 side-by-side, so trying to build it with catkin results in the build missing rosbag2_cpp, which is obviously only needed for ROS2.

Do you want to include catkin/ROS again?
The plotjuggler-ros-plugins for ROS are still based on ros_type_introspection, which you archived two years ago, so I was wondering how easy it would be to migrate them to this library.

@facontidavide
Copy link
Owner

yes, that will eventually happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants