Skip to content

Commit 89258b5

Browse files
spasumarthi21GitHub Enterprise
authored andcommitted
feat(new-sdk-version): Adding 3.0.0 version SDK (#6)
Supported API versions: * v2 Summary: * Making SDK independent of the API version. Breaking changes: * API version is removed from the package name. Functionality Additions: * No changes Bug Fixes: * No changes
1 parent 171b1f6 commit 89258b5

File tree

152 files changed

+916
-681
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

152 files changed

+916
-681
lines changed

CHANGELOG.md

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,27 @@
1+
3.0.0 (12/02/2019)
2+
3+
Supported API versions:
4+
* v2
5+
6+
Summary:
7+
* Making SDK independent of the API version.
8+
9+
Breaking changes:
10+
* API version is removed from the package name.
11+
12+
Functionality Additions:
13+
* No changes
14+
15+
Bug Fixes:
16+
* No changes
17+
18+
-----------------------
19+
120
v2-2.0.0 (09/19/2019)
221

22+
Supported API versions:
23+
* v2
24+
325
Summary:
426
* Update class and property names.
527

@@ -56,7 +78,11 @@ Bug Fixes:
5678
* No changes.
5779

5880
-----------------------
59-
v2-1.0.0 (08/30/2019)
81+
82+
v2-1.0.0 (08/30/2019)
83+
84+
Supported API versions:
85+
* v2
6086

6187
Summary:
6288
* Releasing first version of Engines API(v2).

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# analyticsapi-engines-python-sdk
22

33
## Overview
4-
API client library to leverage Factset's Analytics API in python. Each API version directory contains its respective Analytics API implementation.
4+
API client library to leverage FactSet's PA Engine, SPAR Engine and Vault API in python.
55

6-
**`fds.analyticsapi.engines.vAPI_VERSION`** - Contains the Python library. It is developed using [open-api-generator](https://github.com/OpenAPITools/openapi-generator).
6+
**`fds.analyticsapi.engines`** - Contains the Python library. It is developed using [open-api-generator](https://github.com/OpenAPITools/openapi-generator).
77

88
**`Utilities`** - Contains the EnginesAPI's OpenAPI schema (openapi-schema.json), configuration file (openapi-generator-config.json), OpenAPI's python edited templates and End-to-End tests of library.
99

@@ -12,12 +12,12 @@ API client library to leverage Factset's Analytics API in python. Each API versi
1212

1313
#### Current versions
1414
* API_VERSION - 2
15-
* PACKAGE_VERSION - 2.0.0
15+
* PACKAGE_VERSION - 3.0.0
1616

1717
## To install the API client library
1818
* Run the below command.
1919
```
20-
pip install fds.analyticsapi.engines.vAPI_VERSION-*.*.*.tar.gz
20+
pip install fds.analyticsapi.engines-*.*.*.tar.gz
2121
```
2222

2323
## Generate library
@@ -27,16 +27,16 @@ To customize the OpenAPI generator options and generate the library. Please go t
2727
* Install [Java SDK8 64 bit version](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html).
2828
* Install PyCharm.
2929
* Clone this `analyticsapi-engines-python-sdk` repository.
30-
* Move into the `analyticsapi-engines-python-sdk/API_VERSION/Utilities/codegen` folder and run the `download-codegen.bat` file by double clicking it (for downloading the openapi-generator-cli.jar).
30+
* Move into the `analyticsapi-engines-python-sdk/Utilities/codegen` folder and run the `download-codegen.bat` file by double clicking it (for downloading the openapi-generator-cli.jar).
3131

3232
### To update and build the library
33-
* Move to the `vAPI_VERSION` location.
34-
* Delete all the contents of `fds.analyticsapi.engines.vAPI_VERSION` except `.openapi-generator-ignore` script and `pydocs` sub-directory.
33+
* Move to the `analyticsapi-engines-python-sdk` location.
34+
* Delete all the contents of `fds.analyticsapi.engines` directory except `.openapi-generator-ignore` script.
3535
* In the `Utilities` folder update the `packageVersion` field to new **PACKAGE_VERSION** in `openapi-generator-config.json` file.
36-
* Run the below command after updating **API_VERSION** and **http-user-agent** with correct values.
36+
* Run the below command after updating **PACKAGE_VERSION** with correct values.
3737
```
3838
javac -classpath Utilities/codegen/*; Utilities/codegen/CustomPythonClientCodegen.java
39-
java -DapiTests=false -DmodelTests=false -classpath Utilities/codegen/;Utilities/codegen/*; org.openapitools.codegen.OpenAPIGenerator generate --generator-name CustomPythonClientCodegen --input-spec Utilities/codegen/openapi-schema.json --output fds.analyticsapi.engines.vAPI_VERSION --config Utilities/codegen/openapi-generator-config.json --http-user-agent engines-api/vAPI_VERSION/PACKAGE_VERSION/python --template-dir Utilities/codegen/templates --skip-validate-spec
39+
java -DapiTests=false -DmodelTests=false -classpath Utilities/codegen/;Utilities/codegen/*; org.openapitools.codegen.OpenAPIGenerator generate --generator-name CustomPythonClientCodegen --input-spec Utilities/codegen/openapi-schema.json --output fds.analyticsapi.engines --config Utilities/codegen/openapi-generator-config.json --http-user-agent engines-api/PACKAGE_VERSION/python --template-dir Utilities/codegen/templates --skip-validate-spec
4040
```
4141
* Run the below command which generates API client library in `dist` directory.
4242
```
@@ -48,12 +48,12 @@ python setup.py sdist
4848
#### Running the Test Cases using PyCharm
4949
* Open the PyCharm.
5050
* Goto `File-> Open`.
51-
* Browse for the `vAPI_VERSION/Utilities/test` folder and open it.
51+
* Browse for the `Utilities/test` folder and open it.
5252
* Goto `View-> Tool Windows-> Terminal` and open the terminal.
53-
* In the terminal, move to the location `vAPI_VERSION/fds.analyticsapi.engines.vAPI_VERSION`.
53+
* In the terminal, move to the location `fds.analyticsapi.engines`.
5454
* Install the library.
5555
```
56-
pip install fds.analyticsapi.engines.v*-*.*.*.tar.gz
56+
pip install fds.analyticsapi.engines.*.*.*.tar.gz
5757
```
5858
* Set the below environment variables.
5959
```
File renamed without changes.

v2/Utilities/codegen/download-codegen.bat renamed to Utilities/codegen/download-codegen.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ SETLOCAL
44

55
SET script-path=%~dp0
66

7-
powershell -Command "(new-object System.Net.WebClient).DownloadFile('http://central.maven.org/maven2/org/openapitools/openapi-generator-cli/4.1.1/openapi-generator-cli-4.1.1.jar', '%script-path%openapi-generator-cli-4.1.1.jar')"
7+
powershell -Command "(new-object System.Net.WebClient).DownloadFile('http://central.maven.org/maven2/org/openapitools/openapi-generator-cli/4.2.2/openapi-generator-cli-4.2.2.jar', '%script-path%openapi-generator-cli-4.2.2.jar')"
88

99
ENDLOCAL
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"packageName": "fds.analyticsapi.engines",
3+
"projectName": "fds.analyticsapi.engines",
4+
"packageVersion": "3.0.0",
5+
"packageUrl": "https://github.com/factset/analyticsapi-engines-python-sdk"
6+
}
File renamed without changes.

v2/Utilities/codegen/templates/__init__api.mustache renamed to Utilities/codegen/templates/__init__api.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{! This file is picked from the v4.1.1 release of openapi-generator(https://github.com/OpenAPITools/openapi-generator/blob/v4.1.1/modules/openapi-generator/src/main/resources/python/__init__api.mustache) }}
1+
{{! This file is picked from the v4.2.2 release of openapi-generator(https://github.com/OpenAPITools/openapi-generator/blob/v4.2.2/modules/openapi-generator/src/main/resources/python/__init__api.mustache) }}
22
{{! Changes made: 1) Added import of UtilityApi. }}
33
from __future__ import absolute_import
44

v2/Utilities/codegen/templates/__init__package.mustache renamed to Utilities/codegen/templates/__init__package.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{! This file is picked from the v4.1.1 release of openapi-generator(https://github.com/OpenAPITools/openapi-generator/blob/v4.1.1/modules/openapi-generator/src/main/resources/python/__init__package.mustache) }}
1+
{{! This file is picked from the v4.2.2 release of openapi-generator(https://github.com/OpenAPITools/openapi-generator/blob/v4.2.2/modules/openapi-generator/src/main/resources/python/__init__package.mustache) }}
22
{{! Changes made: 1) Added import of UtilityApi. }}
33
# coding: utf-8
44

v2/Utilities/codegen/templates/common_README.mustache renamed to Utilities/codegen/templates/common_README.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{! This file is picked from the v4.1.1 release of openapi-generator(https://github.com/OpenAPITools/openapi-generator/blob/v4.1.1/modules/openapi-generator/src/main/resources/python/common_README.mustache) }}
1+
{{! This file is picked from the v4.2.2 release of openapi-generator(https://github.com/OpenAPITools/openapi-generator/blob/v4.2.2/modules/openapi-generator/src/main/resources/python/common_README.mustache) }}
22
{{! Changes made: 1) Added link to UtilityApi's documentation. }}
33
```python
44
from __future__ import print_function

0 commit comments

Comments
 (0)