You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of just breaking, an additional check should be done for each each found trigger, in order to control if the distance between triggers is fine.
If triggers are too tight together, a Warning should be logged and the status entry of the related trigger-tag should have a flag to signal the problem to Fesa.
The text was updated successfully, but these errors were encountered:
changed title from Demux_ff - Add error into data-stream if triggers are to tight together to Demux_ff - Add error into data-stream if triggers are to tight together{+ / overlap+}
Edit: This comment is of no relevance. The following is only true for gr-digitizer Version 4.x. Starting with 5.x the feature to support overlapping trigger-windows was removed due to performance problems (See 0a5913d)
On fel0051 (SIS18 Timing, ), GSCD029:TIMING:Triggered@10kHz ... on EVT_COMMAND und CMD_SEQ_START always both trigger pulses can be seen. (1e6 trigger samples, 10MS/s, )
demux_ff can actually generate overlapping trigger windows in gr-digitizer 4.x, but not any more with v 5.x. To be checked if the scope itself can generate overlapping trigger-windows.
In any case, it looks like something goes wrong, when to many trigger-windows are meassured, so we at least should inform FESA via status flag in the tag.
In GitLab by @alexxcons on Mar 19, 2021, 09:39
See "TODO" line in demux_ff_impl.cc
Instead of just breaking, an additional check should be done for each each found trigger, in order to control if the distance between triggers is fine.
If triggers are too tight together, a Warning should be logged and the status entry of the related trigger-tag should have a flag to signal the problem to Fesa.
The text was updated successfully, but these errors were encountered: