feat: eth command #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorShadurin
approved these changes
Dec 6, 2022
src/command/eth/eth-command.ts
Outdated
| import { CommandLineError } from '../../utils/error' | ||
|
|
||
| export class EthCommand extends RootCommand { | ||
| protected provider = new providers.JsonRpcProvider('http://localhost:9545') |
There was a problem hiding this comment.
Does it need to be hardcoded? Maybe it's better to put it in env?
There was a problem hiding this comment.
you cannot change URL parameters in the CLI so it is always contant on the host.
Nevertheless I defined it in the constant.ts instead
src/command/eth/eth-command.ts
Outdated
|
|
||
| const network = await this.provider.getNetwork() | ||
|
|
||
| if (network.chainId !== 4020) { |
There was a problem hiding this comment.
4020 also can also be placed in env
There was a problem hiding this comment.
it is also fixed, but I will put into the constant.ts
|
Release v2.2.0 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
ethgroup command withbalancesendcommands.
The test environment got updated with command log related utility function, namely
describeCommandand other changes regarding how the error handling happens in the CLI.Resolves #72