Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate locale switching during runtime #1054

Closed
xDivisionByZerox opened this issue Jun 10, 2022 · 3 comments
Closed

deprecate locale switching during runtime #1054

xDivisionByZerox opened this issue Jun 10, 2022 · 3 comments
Labels
breaking change Cannot be merged when next version is not a major release c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@xDivisionByZerox
Copy link
Member

Clear and concise description of the problem

I don't see a use case where you wouldn't be able to instantiate a new faker instance with your desired locale and instead need the utility to change an instance's locale during runtime.

Dropping this feature allows some easier separation of concern handling and thus leading to a cleaner architecture for the library.

Suggested solution

Deprecate (and later remove) the public accessibility of:

  • faker.locale
  • faker.locales
  • faker.localeFallback
  • faker.setLocal()

Alternative

No response

Additional context

There is a poll for dropping the feature of switching locales during runtime.

@xDivisionByZerox xDivisionByZerox added s: pending triage Pending Triage c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions labels Jun 10, 2022
@xDivisionByZerox xDivisionByZerox added breaking change Cannot be merged when next version is not a major release s: needs decision Needs team/maintainer decision and removed s: pending triage Pending Triage labels Jun 10, 2022
@Shinigami92
Copy link
Member

This needs to be done together with e.g. #642, because with out that, it's nearly impossible to build own Faker instances.

@ST-DDT
Copy link
Member

ST-DDT commented Jun 11, 2022

IMO its more like a precondition.

@xDivisionByZerox xDivisionByZerox changed the title Proposal: deprecate locale switching during runtime deprecate locale switching during runtime Jul 29, 2022
@xDivisionByZerox xDivisionByZerox added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Jul 29, 2022
@xDivisionByZerox xDivisionByZerox added this to the v8 - Next Major milestone Jul 29, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Sep 6, 2022

Superseded by #1340

@ST-DDT ST-DDT closed this as completed Sep 6, 2022
@ST-DDT ST-DDT moved this to Done in Faker Roadmap Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants