Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): extend Hebrew (he) #1257

Merged
merged 3 commits into from
Aug 16, 2022
Merged

feat(locale): extend Hebrew (he) #1257

merged 3 commits into from
Aug 16, 2022

Conversation

orinaveh
Copy link
Contributor

Description

As a Hebrew speaker who had to use this great package, I found some issues with the Hebrew locales. In this PR, I tried to fix as many of those issues as possible and make the data generated in Hebrew more realistic.

Changes

Address

Buidling Number

I Added common Israeli pattern for semidetached house's Building numbers.

Cities

I Added a list of Israeli cities from our local MOI database.
Therefore I removed the prefix_city file.

Countries

I updated the list as it seemed to be missing many countries.
In addition, I updated the default country to 'Israel' (instead of 'State of Israel') (lit.)

State

I inserted the official regions of Israel to the list.

Streets

In Hebrew, there are no suffixes to street's name, so I replaced the suffix with prefix file that includes common prefixes.
In addition, I took a list of streets names from some of cities in Israel and added that to street_name.ts

Direction Abbreviation

I translated the values.

Cell Phones & Phone numbers

I added the Israeli patterns for Cell Phones and Phone numbers

Color

The translation had Niqqud although using Niqqud is very uncommon in modern Hebrew, so I removed it.

Music

Genres

I refined the translation of some of the genres

Names

First & Last Names

Some names appeared twice or had a suffix of the word 'Family' between parentheses. I also added missing white-spaces.

Prefix

I translated the values.

@orinaveh orinaveh requested a review from a team as a code owner August 11, 2022 19:29
@Shinigami92 Shinigami92 changed the title chore(locales-he): extend he locales feat(locale): extend he locale Aug 11, 2022
@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Aug 11, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #1257 (5fed676) into main (83e5fd3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5fed676 differs from pull request most recent head 1258f3c. Consider uploading reports for the commit 1258f3c to get more accurate results

@@            Coverage Diff            @@
##             main    #1257     +/-   ##
=========================================
  Coverage   99.63%   99.63%             
=========================================
  Files        2156     2154      -2     
  Lines      237000   239941   +2941     
  Branches     1007     1009      +2     
=========================================
+ Hits       236125   239065   +2940     
- Misses        854      855      +1     
  Partials       21       21             
Impacted Files Coverage Δ
src/locales/he/name/index.ts 100.00% <ø> (ø)
src/locales/he/address/building_number.ts 100.00% <100.00%> (ø)
src/locales/he/address/city.ts 100.00% <100.00%> (ø)
src/locales/he/address/city_name.ts 100.00% <100.00%> (ø)
src/locales/he/address/country.ts 100.00% <100.00%> (ø)
src/locales/he/address/default_country.ts 100.00% <100.00%> (ø)
src/locales/he/address/direction_abbr.ts 100.00% <100.00%> (ø)
src/locales/he/address/index.ts 100.00% <100.00%> (ø)
src/locales/he/address/state.ts 100.00% <100.00%> (ø)
src/locales/he/address/street.ts 100.00% <100.00%> (ø)
... and 13 more

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed half of this PR and will do the rest tomorrow.
It looks good so far, I only had one word that I couldn't very using google translate.

src/locales/he/music/genre.ts Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented Aug 11, 2022

Thanks for your contribution!

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Aug 11, 2022
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/locales/he/phone_number/formats.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 changed the title feat(locale): extend he locale feat(locale): extend Hebrew (he) Aug 13, 2022
@ST-DDT ST-DDT requested review from a team August 15, 2022 08:20
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 16, 2022 08:36
@Shinigami92 Shinigami92 merged commit f8c9f60 into faker-js:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants