-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): extend Hebrew (he) #1257
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1257 +/- ##
=========================================
Coverage 99.63% 99.63%
=========================================
Files 2156 2154 -2
Lines 237000 239941 +2941
Branches 1007 1009 +2
=========================================
+ Hits 236125 239065 +2940
- Misses 854 855 +1
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed half of this PR and will do the rest tomorrow.
It looks good so far, I only had one word that I couldn't very using google translate.
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
As a Hebrew speaker who had to use this great package, I found some issues with the Hebrew locales. In this PR, I tried to fix as many of those issues as possible and make the data generated in Hebrew more realistic.
Changes
Address
Buidling Number
I Added common Israeli pattern for semidetached house's Building numbers.
Cities
I Added a list of Israeli cities from our local MOI database.
Therefore I removed the prefix_city file.
Countries
I updated the list as it seemed to be missing many countries.
In addition, I updated the default country to 'Israel' (instead of 'State of Israel') (lit.)
State
I inserted the official regions of Israel to the list.
Streets
In Hebrew, there are no suffixes to street's name, so I replaced the suffix with prefix file that includes common prefixes.
In addition, I took a list of streets names from some of cities in Israel and added that to
street_name.ts
Direction Abbreviation
I translated the values.
Cell Phones & Phone numbers
I added the Israeli patterns for Cell Phones and Phone numbers
Color
The translation had Niqqud although using Niqqud is very uncommon in modern Hebrew, so I removed it.
Music
Genres
I refined the translation of some of the genres
Names
First & Last Names
Some names appeared twice or had a suffix of the word 'Family' between parentheses. I also added missing white-spaces.
Prefix
I translated the values.