Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian locale partially not working in Name module #1352

Closed
8 of 10 tasks
SkifAlef opened this issue Sep 7, 2022 · 2 comments
Closed
8 of 10 tasks

Russian locale partially not working in Name module #1352

SkifAlef opened this issue Sep 7, 2022 · 2 comments
Labels
c: bug Something isn't working duplicate Duplicate of another issue/PR

Comments

@SkifAlef
Copy link

SkifAlef commented Sep 7, 2022

Pre-Checks

Describe the bug

Faker doesn't use locale (at least 'ru') when I'm using name.firstName() or lastName() without sex parameter.
I.e. faker.name.lastName('female') generates valid Russian last name, for example, Иванова
But faker.name.lastName() generates fallback English last name like Smith

Minimal reproduction code

https://stackblitz.com/edit/faker-js-demo-lvrleu?file=index.ts

Additional Context

No response

Environment Info

System:
    OS: Windows 10 10.0.19044
    CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700KF
    Memory: 38.74 GB / 63.85 GB
  Binaries:
    Node: 16.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.2.0 - C:\Program Files\nodejs\yarn.CMD
    npm: 8.11.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (105.0.1343.27)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    @faker-js/faker: ^7.5.0 => 7.5.0

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

yarn

@SkifAlef SkifAlef added c: bug Something isn't working s: pending triage Pending Triage labels Sep 7, 2022
@Shinigami92
Copy link
Member

Please provide a src/locales/ru/name/first_name.ts and src/locales/ru/name/last_name.ts

@ST-DDT
Copy link
Member

ST-DDT commented Sep 7, 2022

Duplicate of #547

@ST-DDT ST-DDT marked this as a duplicate of #547 Sep 7, 2022
@ST-DDT ST-DDT closed this as completed Sep 7, 2022
@xDivisionByZerox xDivisionByZerox added duplicate Duplicate of another issue/PR and removed s: pending triage Pending Triage labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working duplicate Duplicate of another issue/PR
Projects
None yet
Development

No branches or pull requests

4 participants