Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(locale)!: change en_IND to en_IN #1448

Merged
merged 4 commits into from
Oct 14, 2022
Merged

refactor(locale)!: change en_IND to en_IN #1448

merged 4 commits into from
Oct 14, 2022

Conversation

wael-fadlallah
Copy link
Contributor

@wael-fadlallah wael-fadlallah commented Oct 14, 2022 •
edited
Loading

For #1354

@wael-fadlallah wael-fadlallah requested a review from a team October 14, 2022 21:18
@wael-fadlallah wael-fadlallah requested a review from a team as a code owner October 14, 2022 21:18
@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions breaking change Cannot be merged when next version is not a major release needs rebase There is a merge conflict labels Oct 14, 2022
@Shinigami92
Copy link
Member

@wael-fadlallah looks like you didn't changed first to the next / default branch

@wael-fadlallah wael-fadlallah deleted the refactor-IND-locale branch October 14, 2022 21:41
@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Merging #1448 (4173eef) into next (b99ff71) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1448      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.02%     
==========================================
  Files        2164     2164              
  Lines      236810   236810              
  Branches     1003      999       -4     
==========================================
- Hits       235911   235887      -24     
- Misses        877      901      +24     
  Partials       22       22
Impacted Files Coverage Δ
src/locales/en_IN/address/city.ts 100.00% <ø> (ø)
src/locales/en_IN/address/city_name.ts 100.00% <ø> (ø)
src/locales/en_IN/address/default_country.ts 100.00% <ø> (ø)
src/locales/en_IN/address/index.ts 100.00% <ø> (ø)
src/locales/en_IN/address/postcode.ts 100.00% <ø> (ø)
src/locales/en_IN/address/state.ts 100.00% <ø> (ø)
src/locales/en_IN/address/state_abbr.ts 100.00% <ø> (ø)
src/locales/en_IN/address/street.ts 100.00% <ø> (ø)
src/locales/en_IN/company/index.ts 100.00% <ø> (ø)
src/locales/en_IN/company/suffix.ts 100.00% <ø> (ø)
... and 12 more

@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Oct 14, 2022
@Shinigami92 Shinigami92 requested review from a team October 14, 2022 22:13
@Shinigami92 Shinigami92 linked an issue Oct 14, 2022 that may be closed by this pull request
en_IND locale should be en_IN #1354
Closed
10 tasks
@Shinigami92 Shinigami92 changed the title refactor(locale)!: changed en_IND locale to en_IN refactor(locale)!: changed en_IND to en_IN Oct 14, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 14, 2022 22:14
@Shinigami92 Shinigami92 changed the title refactor(locale)!: changed en_IND to en_IN refactor(locale)!: change en_IND to en_IN Oct 14, 2022
@Shinigami92 Shinigami92 disabled auto-merge October 14, 2022 23:34
@Shinigami92 Shinigami92 changed the title refactor(locale)!: change en_IND to en_IN refactor(locale)!: changed the en_IND locale to en_IN Oct 14, 2022
@Shinigami92 Shinigami92 changed the title refactor(locale)!: changed the en_IND locale to en_IN refactor(locale)!: change the en_IND locale to en_IN Oct 14, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 14, 2022 23:35
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Oct 14, 2022
@Shinigami92 Shinigami92 disabled auto-merge October 14, 2022 23:39
@Shinigami92 Shinigami92 changed the title refactor(locale)!: change the en_IND locale to en_IN refactor(locale)!: changed the en_IND locale to en_IN Oct 14, 2022
@Shinigami92 Shinigami92 changed the title refactor(locale)!: changed the en_IND locale to en_IN refactor(locale)!: change en_IND to en_IN Oct 14, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) October 14, 2022 23:39
@Shinigami92 Shinigami92 merged commit a7cd422 into faker-js:next Oct 14, 2022
@matthewmayer
Copy link
Contributor

matthewmayer commented Oct 15, 2022 •
edited
Loading

Can en_IND be made an alias (throwing a warning) for en_IN for v8 and then removed completely in v9?

@Shinigami92
Copy link
Member

Can en_IND be made an alias (throwing a warning) for en_IN for v8 and then removed completely in v9?

@matthewmayer Please open a PR to tackle this, or open a new issue so we can make that visible and not miss it before releasing v8.0.
A comment in a already closed/merged PR will likely go under and unseen ⚠️

@matthewmayer matthewmayer mentioned this pull request Oct 15, 2022
Closed
10 tasks
@matthewmayer
Copy link
Contributor

Can en_IND be made an alias (throwing a warning) for en_IN for v8 and then removed completely in v9?

@matthewmayer Please open a PR to tackle this, or open a new issue so we can make that visible and not miss it before releasing v8.0. A comment in a already closed/merged PR will likely go under and unseen ⚠️

sure #1454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@wael-fadlallah wael-fadlallah

Labels
breaking change Cannot be merged when next version is not a major release c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

en_IND locale should be en_IN
5 participants
@wael-fadlallah @Shinigami92 @matthewmayer @ST-DDT @import-brain