Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New method: string.special #1467

Closed
Shinigami92 opened this issue Oct 17, 2022 · 5 comments · Fixed by #1634
Closed

New method: string.special #1467

Shinigami92 opened this issue Oct 17, 2022 · 5 comments · Fixed by #1634
Assignees
@notbrayton
Labels
c: feature Request for new feature good first issue Good for newcomers m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@Shinigami92
Copy link
Member

Clear and concise description of the problem

Extracted from #1155 (comment)

Suggested solution

Add a string.special method that returns only special characters

Alternative

No response

Additional context

No response
@Shinigami92 Shinigami92 added c: feature Request for new feature m: string Something is referring to the string module labels Oct 17, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Oct 17, 2022
@Shinigami92 Shinigami92 added the good first issue Good for newcomers label Oct 17, 2022
@Shinigami92 Shinigami92 mentioned this issue Oct 17, 2022
Merged
@Minozzzi
Copy link
Contributor

Could I work on it?

@ST-DDT
Copy link
Member

ST-DDT commented Oct 17, 2022

Sure, but please wait till the string module PR is merged.

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 17, 2022
@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Oct 18, 2022
@Shinigami92
Copy link
Member Author

@Minozzzi you can start

@notbrayton
Copy link
Contributor

Hi, it seems like there has not been much action on this issue in a while. If that is the case, I would love the opportunity to tackle this issue.

@Minozzzi
Copy link
Contributor

Minozzzi commented Dec 1, 2022

You can go ahead, it's really hard for me to make time for this :c

@Minozzzi Minozzzi removed their assignment Dec 1, 2022
@notbrayton notbrayton mentioned this issue Dec 6, 2022
Merged
@ST-DDT ST-DDT linked a pull request Dec 6, 2022 that will close this issue
feat(string): add special() method #1634
Merged
@ST-DDT ST-DDT moved this from Todo to Awaiting Review in Faker Roadmap Dec 6, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notbrayton notbrayton

Labels
c: feature Request for new feature good first issue Good for newcomers m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

feat(string): add special() method
4 participants
@ST-DDT @Shinigami92 @notbrayton @Minozzzi