-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datatype): introduce probability option to boolean #1476
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1476 +/- ##
=======================================
Coverage 99.63% 99.64%
=======================================
Files 2175 2175
Lines 237613 237636 +23
Branches 1009 1013 +4
=======================================
+ Hits 236751 236782 +31
+ Misses 841 833 -8
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into the test snapshots, it looks like the behavior exactly swapped, true is now false and false is now true 🤔
Should we just switch the condition to archive the "old" result(s)?
IMO the probability should refer to true and not false. I dont know how to preserve the old behavior that wouldn't result in bad code readability/understandability. |
5421688
705ca55
to
6a66cc8
Compare
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Throughout our code base the have some locations that use probabilities to decide what to do.
This PR merges these occurrences into our
datatype.boolean()
method and thus provides this option to others.Docs Preview