-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helpers): introduce multiple
method
#1545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: feature
Request for new feature
p: 1-normal
Nothing urgent
m: helpers
Something is referring to the helpers module
labels
Nov 9, 2022
Blocked till #1486 is merged. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1545 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2222 2222
Lines 240495 240500 +5
Branches 1069 1066 -3
=======================================
+ Hits 239593 239598 +5
Misses 881 881
Partials 21 21
|
ST-DDT
changed the title
feat(helpers): introduce multiple method
feat(helpers): introduce Nov 9, 2022
multiple
method
ST-DDT
force-pushed
the
feat/helpers/multiple
branch
from
November 21, 2022 19:17
cc23b32
to
7c5a3b4
Compare
ST-DDT
commented
Nov 21, 2022
ST-DDT
commented
Nov 21, 2022
Shinigami92
previously approved these changes
Dec 6, 2022
import-brain
previously approved these changes
Dec 6, 2022
import-brain
previously approved these changes
Dec 6, 2022
xDivisionByZerox
previously approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will already approve as I don't think the test name reword is thaaat important.
ST-DDT
dismissed stale reviews from xDivisionByZerox and import-brain
via
December 7, 2022 09:32
5774fb7
Co-authored-by: Leyla Jähnig <leyla.jaehnig@gmx.de>
xDivisionByZerox
approved these changes
Dec 7, 2022
import-brain
approved these changes
Dec 7, 2022
Shinigami92
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: feature
Request for new feature
m: helpers
Something is referring to the helpers module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method to generate multiple values from a method.
In our code we have a few of places that generate multiple values from a single method:
faker/src/modules/system/index.ts
Lines 80 to 81 in 8bf7162
faker/src/modules/string/index.ts
Lines 163 to 165 in 02f3967
faker/src/modules/color/index.ts
Lines 323 to 325 in 79858fe
faker/src/modules/datatype/index.ts
Lines 301 to 303 in 838f836
faker/src/modules/finance/index.ts
Line 345 in 838f836
Example
Planned features