Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct the logic of first_name in en_GH locale #1566

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix: correct the logic of first_name in en_GH locale #1566

merged 2 commits into from
Nov 18, 2022

Conversation

wael-fadlallah
Copy link
Contributor

For issue #1552

@wael-fadlallah wael-fadlallah requested a review from a team as a code owner November 16, 2022 12:36
@codecov
Copy link

codecov bot commented Nov 16, 2022 •
edited
Loading

Codecov Report

Merging #1566 (5671f16) into next (1796559) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1566   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2214     2214           
  Lines      238812   238815    +3     
  Branches     1029     1029           
=======================================
+ Hits       237950   237953    +3     
  Misses        841      841           
  Partials       21       21
Impacted Files Coverage Δ
src/locales/en_GH/person/first_name.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 16, 2022
@ST-DDT ST-DDT linked an issue Nov 16, 2022 that may be closed by this pull request
firstName is broken in en_GH (Ghana) #1552
Closed
10 tasks
@ST-DDT ST-DDT merged commit dfd74f2 into faker-js:next Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@wael-fadlallah wael-fadlallah

Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

firstName is broken in en_GH (Ghana)
4 participants
@wael-fadlallah @ST-DDT @Shinigami92 @import-brain