Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locate): add japanese company #1573

Merged
merged 2 commits into from
Nov 21, 2022
Merged

feat(locate): add japanese company #1573

merged 2 commits into from
Nov 21, 2022

Conversation

kz-d
Copy link
Contributor

@kz-d kz-d commented Nov 20, 2022

@kz-d kz-d requested a review from a team as a code owner November 20, 2022 08:13
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels Nov 20, 2022
@codecov
Copy link

codecov bot commented Nov 20, 2022 •
edited
Loading

Codecov Report

Merging #1573 (975c40f) into next (f30c111) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1573      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files        2216     2220       +4     
  Lines      238921   238959      +38     
  Branches     1040     1039       -1     
==========================================
+ Hits       238062   238097      +35     
- Misses        838      841       +3     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/ja/company/category.ts 100.00% <100.00%> (ø)
src/locales/ja/company/index.ts 100.00% <100.00%> (ø)
src/locales/ja/company/name_patterns.ts 100.00% <100.00%> (ø)
src/locales/ja/company/type.ts 100.00% <100.00%> (ø)
src/locales/ja/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 92.59% <0.00%> (-0.80%) ⬇️

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Nov 20, 2022
@ST-DDT ST-DDT mentioned this pull request Nov 20, 2022
Closed
@Shinigami92
Copy link
Member

@kiaking Hey my japanese friend 🙃
Can you approve this patterns?

kiaking
kiaking approved these changes Nov 21, 2022
View reviewed changes
Copy link

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this looks reasonable 👍 I don't see any problematic words here 🙌

@ST-DDT ST-DDT enabled auto-merge (squash) November 21, 2022 18:37
@ST-DDT ST-DDT merged commit 6e1009a into faker-js:next Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@kiaking kiaking kiaking approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@kz-d kz-d

Labels
c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@kz-d @Shinigami92 @ST-DDT @kiaking