Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(number)!: change int default params #1643

Merged
merged 11 commits into from
Dec 17, 2022
Merged

feat(number)!: change int default params #1643

merged 11 commits into from
Dec 17, 2022

Conversation

Shinigami92
Copy link
Member

closes #1598

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Dec 9, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Dec 9, 2022
@Shinigami92 Shinigami92 self-assigned this Dec 9, 2022
@Shinigami92 Shinigami92 added the m: number Something is referring to the number module label Dec 9, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review December 9, 2022 11:29
@Shinigami92 Shinigami92 requested a review from a team as a code owner December 9, 2022 11:29
@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Merging #1643 (201511e) into next (b7dbfac) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1643   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2222     2222           
  Lines      240133   240133           
  Branches     1050     1051    +1     
=======================================
  Hits       239261   239261           
  Misses        851      851           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/number/index.ts 100.00% <100.00%> (ø)

ST-DDT
ST-DDT reviewed Dec 9, 2022
View reviewed changes
src/modules/datatype/index.ts Outdated Show resolved Hide resolved
src/modules/image/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 9, 2022
@ST-DDT ST-DDT requested review from a team December 9, 2022 13:27
@Shinigami92 Shinigami92 requested a review from ST-DDT December 10, 2022 19:26
@Shinigami92
Copy link
Member Author

Want to leave this comment that it's a bit against my personal decision doing these last changes, but as I don't even use these methods myself, I don't care that much 🤷

@Shinigami92 Shinigami92 requested a review from ST-DDT December 10, 2022 20:15
@ST-DDT ST-DDT merged commit 0b2fa1a into next Dec 17, 2022
@ST-DDT ST-DDT deleted the 1598-change-numberint-default-max-to-numbermax_safe_integer branch December 17, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Change number.int default max to Number.MAX_SAFE_INTEGER
4 participants
@Shinigami92 @ST-DDT @import-brain @xDivisionByZerox