Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove git commit hooks #1683

Closed
Shinigami92 opened this issue Dec 25, 2022 · 0 comments · Fixed by #1684
Closed

Remove git commit hooks #1683

Shinigami92 opened this issue Dec 25, 2022 · 0 comments · Fixed by #1684
Assignees
@Shinigami92
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@Shinigami92
Copy link
Member

Lets remove git commit hooks and just depend fully on CI

At first they were useful as we were not aware of any changes a contributor could slip in, but now after around one year we have stabilized out CI to a level were we can trust it

This will speed up and simplify contributing to Faker
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Dec 25, 2022
@Shinigami92 Shinigami92 self-assigned this Dec 25, 2022
@Shinigami92 Shinigami92 moved this to In Progress in Faker Roadmap Dec 25, 2022
@Shinigami92 Shinigami92 mentioned this issue Dec 25, 2022
Merged
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap Dec 25, 2022
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 25, 2022
@ST-DDT ST-DDT mentioned this issue Dec 25, 2022
Closed
3 tasks
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shinigami92 Shinigami92

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

infra: remove git commit hooks faker-js/faker
2 participants
@ST-DDT @Shinigami92