-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add base locale #1748
feat: add base locale #1748
Conversation
Uncommitted changes were detected after runnning |
As we have currently not the possibility to declare multiple stacked there we can finally use e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay will revert the color, and potentially convert the color related things to enums in another PR But I can proceed with stuff like emoji and other already locales that are in |
TBD Maybe move to global?
Maybe move to another locale?
Maybe purge?
|
b0cccb2
to
ef5c56c
Compare
#1735 is merged, so this is no longer blocked. Most/All(?) of the merge conflicts can be solved by running |
TODO:
|
7bb31d8
to
07a2054
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1748 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 2450 2458 +8
Lines 239748 239905 +157
Branches 1276 1276
==========================================
+ Hits 238864 239004 +140
- Misses 862 878 +16
- Partials 22 23 +1
|
Poll Decision
|
Co-authored-by: Matt Mayer <152770+matthewmayer@users.noreply.github.com>
closes #1441
this adds a global locale that can later be used as the fallback for everything
it contains just generic data not related to a locale specifically, like e.g. css_space which are the same in every locale in the world