Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faker.helpers.objectEntry #1764

Closed
ST-DDT opened this issue Jan 22, 2023 · 11 comments · Fixed by #2123
Closed

Add faker.helpers.objectEntry #1764

ST-DDT opened this issue Jan 22, 2023 · 11 comments · Fixed by #2123
Assignees
Labels
c: feature Request for new feature good first issue Good for newcomers m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2023

So we could use ObjectKeys to get a random key and then get the values for it.
Or alternatively we introduce objectEntry that returns [key, value] directly.

What do you think?

Originally posted by @ST-DDT in #1761 (comment)

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision m: helpers Something is referring to the helpers module labels Jan 22, 2023
@ST-DDT ST-DDT moved this to Awaiting Review in Faker Roadmap Jan 22, 2023
@ST-DDT ST-DDT moved this from Awaiting Review to Todo in Faker Roadmap Jan 22, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 16, 2023

Team Decision

We want this.

@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug good first issue Good for newcomers and removed s: needs decision Needs team/maintainer decision labels Feb 16, 2023
@Janaki4
Copy link

Janaki4 commented Mar 30, 2023

Hey , I would i like to work on this . Is this issue still open . If Yes , can you assign it to me ? Thanks

@Janaki4
Copy link

Janaki4 commented Apr 1, 2023

hey , I see no documents are there for setting up the enviropnment . Can you please share any document or steps to set up environment ? Thanks

@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 1, 2023

You need Git, an IDE such as VS Code, Node and pnpm.
Please search for yourself on how to download and install them.
If you are done with that you have to clone this repository and open it with your IDE.
See also: https://docs.github.com/en/get-started/exploring-projects-on-github/finding-ways-to-contribute-to-open-source-on-github

@Janaki4
Copy link

Janaki4 commented Apr 2, 2023

@ST-DDT , I got that. I'm trying to build the project by following the steps in CONTRIBUTION.md . (pnpm install , and pnpm run build) . But itss not helping . Project doesn't start or run . Please guide me on this.

@matthewmayer
Copy link
Contributor

matthewmayer commented Apr 2, 2023

Please paste the full output of what you see when you type pnpm install and pnpm run build.

@Janaki4
Copy link

Janaki4 commented Apr 2, 2023

Faker
@matthewmayer , Nothing runs or start when i run these commands. FYI : I'm using windows.

@ST-DDT
Copy link
Member Author

ST-DDT commented Apr 2, 2023

Nothing is supposed to run as this is a library.
Is there anything that lead you to this assumption that we can improve?

You just have to add the method implementation and tests for this feature.
We also have a playground repository that you can use to test the code yourself via pnpm dependency overwrite linking to your local fork.

@matthewmayer
Copy link
Contributor

Faker

@matthewmayer , Nothing runs or start when i run these commands. FYI : I'm using windows.

It seems to be working fine.

You would then need to make changes to the code for example to add the new objectEntry method

When you have finished run pnpm run build again. Assuming no errors then run node to enter the node CLI where you can test everything works as you expect.

@Janaki4
Copy link

Janaki4 commented Apr 2, 2023

Okay guys.

@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap May 3, 2023
@Shinigami92 Shinigami92 linked a pull request May 3, 2023 that will close this issue
@suyashgulati
Copy link
Contributor

I have created a PR for this issue #2123
Can someone please assign this issue to me?
cc: @Shinigami92

@github-project-automation github-project-automation bot moved this from In Progress to Done in Faker Roadmap May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature good first issue Good for newcomers m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants