Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helpers): add length range support in arrayElements #1772

Merged
merged 10 commits into from
Jan 26, 2023
Merged

feat(helpers): add length range support in arrayElements #1772

merged 10 commits into from
Jan 26, 2023

Conversation

ejcheng
Copy link
Member

@ejcheng ejcheng commented Jan 23, 2023

closes #1771

@ejcheng ejcheng added c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: helpers Something is referring to the helpers module labels Jan 23, 2023
@ejcheng ejcheng requested a review from a team January 23, 2023 16:29
@ejcheng ejcheng requested a review from a team as a code owner January 23, 2023 16:29
@ejcheng ejcheng self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Merging #1772 (f094b47) into next (c7ce35a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f094b47 differs from pull request most recent head b10eb2d. Consider uploading reports for the commit b10eb2d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1772   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2340     2340           
  Lines      242654   242669   +15     
  Branches     1110     1112    +2     
=======================================
+ Hits       241802   241819   +17     
+ Misses        831      829    -2     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/helpers/index.ts 99.20% <100.00%> (+0.21%) ⬆️

@ejcheng @xDivisionByZerox
Update test/helpers.spec.ts
4ff96ba 
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
ST-DDT
ST-DDT reviewed Jan 24, 2023
View reviewed changes
ST-DDT
ST-DDT approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for addressing this.

@ST-DDT ST-DDT requested review from Shinigami92 and a team January 25, 2023 14:38
@ST-DDT ST-DDT enabled auto-merge (squash) January 26, 2023 16:04
Shinigami92
Shinigami92 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now this is an improvement
Later on we could maybe do what I have in my mind and return just random elements out of the given set

@ST-DDT ST-DDT merged commit b86638d into next Jan 26, 2023
@ST-DDT ST-DDT deleted the feat/count_ranges_arrayElements branch January 26, 2023 16:13
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@ejcheng @matthewmayer
feat(helpers): add length range support in arrayElements (faker-js#…
52bcabd 
…1772)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@ejcheng ejcheng

Labels
c: feature Request for new feature m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Add support for count ranges in helpers.arrayElements
4 participants
@ejcheng @ST-DDT @Shinigami92 @xDivisionByZerox