-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(person): avoid repeated last name via new last_name_patterns #1819
Merged
ST-DDT
merged 10 commits into
faker-js:next
from
matthewmayer:fix/person-last-name-patterns
Feb 21, 2023
Merged
fix(person): avoid repeated last name via new last_name_patterns #1819
ST-DDT
merged 10 commits into
faker-js:next
from
matthewmayer:fix/person-last-name-patterns
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmayer
commented
Feb 9, 2023
matthewmayer
commented
Feb 9, 2023
ST-DDT
reviewed
Feb 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1819 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 2345 2355 +10
Lines 236241 236323 +82
Branches 1150 1154 +4
==========================================
+ Hits 235393 235467 +74
- Misses 826 834 +8
Partials 22 22
|
10 tasks
ST-DDT
added
p: 1-normal
Nothing urgent
s: needs decision
Needs team/maintainer decision
c: bug
Something isn't working
c: locale
Permutes locale definitions
labels
Feb 12, 2023
xDivisionByZerox
added
the
s: on hold
Blocked by something or frozen to avoid conflicts
label
Feb 13, 2023
Team Decision We will use this approach, but we would like to use the fake function (in combination with person.last_name) instead of mustache, to allow custom pattern parts. We will revisit this/the pattern as part of #1677 . |
ST-DDT
added
s: accepted
Accepted feature / Confirmed bug
and removed
s: on hold
Blocked by something or frozen to avoid conflicts
s: needs decision
Needs team/maintainer decision
labels
Feb 16, 2023
So this is temporarily on hold until #1677 is implemented? |
matthewmayer
commented
Feb 16, 2023
ST-DDT
reviewed
Feb 17, 2023
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
about 10% of names are hyphenated in UK https://www.theguardian.com/lifeandstyle/2017/nov/02/keeping-up-with-smith-joneses-no-longer-posh-double-barrelled-surname
Shinigami92
approved these changes
Feb 20, 2023
ST-DDT
approved these changes
Feb 20, 2023
xDivisionByZerox
approved these changes
Feb 20, 2023
ST-DDT
changed the title
fix(person): avoid repeated double last name via new last_name_patterns
fix(person): avoid repeated last name via new last_name_patterns
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: bug
Something isn't working
c: locale
Permutes locale definitions
m: person
Something is referring to the person module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1817
an alternative strategy which allows for compound and hyphenated last names. The advantage of this is that it works for both
faker.person.lastName()
as well asfaker.person.fullName()
Here's 100 fullNames for each of the affected locales