Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unrelatistic elements from de_CH/location/country_code #1861

Closed
ST-DDT opened this issue Feb 20, 2023 · 2 comments · Fixed by #2304
Closed

Remove unrelatistic elements from de_CH/location/country_code #1861

ST-DDT opened this issue Feb 20, 2023 · 2 comments · Fixed by #2304
Assignees
@import-brain
Labels
c: locale Permutes locale definitions good first issue Good for newcomers m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 20, 2023

faker/src/locales/de_CH/location/country_code.ts

Line 1 in 3e11027

export default ['CH', 'DE', 'AT', 'US', 'LI', 'HK', 'VN'];

Found in https://github.com/faker-js/faker/pull/1720/files#r1112031288
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Feb 20, 2023
@ST-DDT ST-DDT mentioned this issue Feb 20, 2023
Merged
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 20, 2023

Blocked to avoid conflict with: #1720

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts s: accepted Accepted feature / Confirmed bug labels Feb 20, 2023
@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Feb 20, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 29, 2023

#1720 is merged, so this is no longer blocked.

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Mar 29, 2023
@xDivisionByZerox xDivisionByZerox added the good first issue Good for newcomers label Jul 14, 2023
@import-brain import-brain self-assigned this Aug 9, 2023
This was referenced Aug 10, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@import-brain import-brain

Labels
c: locale Permutes locale definitions good first issue Good for newcomers m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Todo
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

fix: remove unrelated entries from de_CH country codes faker-js/faker
3 participants
@ST-DDT @import-brain @xDivisionByZerox