Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistent locale names #1884

Merged
merged 4 commits into from
Mar 7, 2023
Merged

fix: consistent locale names #1884

merged 4 commits into from
Mar 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 28, 2023

Use consistent locale naming for en_NB and fr_BE.

@ST-DDT ST-DDT added c: bug Something isn't working c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Feb 28, 2023
@ST-DDT ST-DDT self-assigned this Feb 28, 2023
@ST-DDT ST-DDT requested a review from a team February 28, 2023 20:48
@ST-DDT ST-DDT requested a review from a team as a code owner February 28, 2023 20:48
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 28, 2023

Blocked by #1735 to avoid merge conflicts.

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Feb 28, 2023
@ST-DDT ST-DDT mentioned this pull request Feb 28, 2023
Merged
@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #1884 (49de925) into next (4f720ef) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1884      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2356     2356              
  Lines      236565   236565              
  Branches     1195     1196       +1     
==========================================
- Hits       235692   235690       -2     
- Misses        851      853       +2     
  Partials       22       22
Impacted Files Coverage Δ
src/definitions/definitions.ts 0.00% <0.00%> (ø)
src/locales/dv/index.ts 100.00% <100.00%> (ø)
src/locales/en_NG/index.ts 100.00% <100.00%> (ø)
src/locales/fr_BE/index.ts 100.00% <100.00%> (ø)
src/locales/hr/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 92.89% <0.00%> (-0.60%) ⬇️

@ST-DDT ST-DDT added needs rebase There is a merge conflict and removed s: on hold Blocked by something or frozen to avoid conflicts labels Mar 7, 2023
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Mar 7, 2023
@ST-DDT ST-DDT requested a review from a team March 7, 2023 12:49
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 7, 2023

Ready to review

matthewmayer
matthewmayer previously approved these changes Mar 7, 2023
View reviewed changes
@ST-DDT ST-DDT requested a review from a team March 7, 2023 13:18
Shinigami92
Shinigami92 previously approved these changes Mar 7, 2023
View reviewed changes
@ST-DDT ST-DDT enabled auto-merge (squash) March 7, 2023 15:46
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 7, 2023
matthewmayer
matthewmayer reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HR should be Croatian and DV should be Maldivian if we are standardising on English names rather than endonyms.

@ST-DDT ST-DDT disabled auto-merge March 7, 2023 15:55
@ST-DDT ST-DDT dismissed stale reviews from Shinigami92 and matthewmayer via 49de925 March 7, 2023 16:13
@ST-DDT ST-DDT requested review from a team March 7, 2023 16:13
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 7, 2023

HR should be Croatian and DV should be Maldivian if we are standardising on English names rather than endonyms.

Done.

FFR: I plan to add a nativeTitle with the name in the chosen language: de_AT => Österreichisch (Österreich)?

@ST-DDT ST-DDT merged commit cf2ce68 into next Mar 7, 2023
@ST-DDT ST-DDT deleted the fix/consistent-locale-names branch March 7, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working c: docs Improvements or additions to documentation c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @matthewmayer @Shinigami92 @xDivisionByZerox