Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add locale TH #1922

Merged
merged 17 commits into from
Apr 2, 2023
Merged

feat(locale): add locale TH #1922

merged 17 commits into from
Apr 2, 2023

Conversation

munkeawtoast
Copy link
Contributor

Fixed all problems with the latter PR #1921 .

@munkeawtoast munkeawtoast requested a review from a team March 12, 2023 18:20
@munkeawtoast munkeawtoast requested a review from a team as a code owner March 12, 2023 18:20
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Mar 12, 2023
@ST-DDT ST-DDT requested a review from a team March 12, 2023 23:49
@codecov
Copy link

codecov bot commented Mar 12, 2023 •
edited
Loading

Codecov Report

Merging #1922 (d8c0e17) into next (caf58d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             next    #1922     +/-   ##
=========================================
  Coverage   99.61%   99.62%             
=========================================
  Files        2527     2560     +33     
  Lines      240724   243199   +2475     
  Branches     1272     1278      +6     
=========================================
+ Hits       239796   242281   +2485     
+ Misses        903      893     -10     
  Partials       25       25
Impacted Files Coverage Δ
src/locale/index.ts 100.00% <100.00%> (ø)
src/locale/th.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/th/animal/cat.ts 100.00% <100.00%> (ø)
src/locales/th/animal/dog.ts 100.00% <100.00%> (ø)
src/locales/th/animal/index.ts 100.00% <100.00%> (ø)
src/locales/th/color/human.ts 100.00% <100.00%> (ø)
src/locales/th/color/index.ts 100.00% <100.00%> (ø)
src/locales/th/date/index.ts 100.00% <100.00%> (ø)
src/locales/th/date/month.ts 100.00% <100.00%> (ø)
... and 25 more

... and 2 files with indirect coverage changes

matthewmayer
matthewmayer previously approved these changes Mar 13, 2023
View reviewed changes
src/locales/th/person/index.ts Show resolved Hide resolved
matthewmayer
matthewmayer previously approved these changes Mar 29, 2023
View reviewed changes
Shinigami92
Shinigami92 reviewed Mar 29, 2023
View reviewed changes
src/locales/th/location/street_name.ts Show resolved Hide resolved
src/locales/th/location/street_name.ts Show resolved Hide resolved
src/locales/th/location/street_name.ts Show resolved Hide resolved
src/locales/th/location/street_name.ts Show resolved Hide resolved
src/locales/th/location/street_name.ts Show resolved Hide resolved
src/locales/th/location/street_name.ts Show resolved Hide resolved
src/locales/th/person/last_name.ts Outdated Show resolved Hide resolved
src/locales/th/person/name.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Mar 29, 2023
View reviewed changes
ST-DDT
ST-DDT previously approved these changes Mar 29, 2023
View reviewed changes
@ST-DDT ST-DDT requested a review from matthewmayer March 29, 2023 18:12
@ST-DDT ST-DDT requested review from Shinigami92 and a team March 29, 2023 18:12
Shinigami92
Shinigami92 previously approved these changes Mar 31, 2023
View reviewed changes
@ST-DDT ST-DDT dismissed stale reviews from Shinigami92 and themself via e8b05bd April 1, 2023 19:50
@ST-DDT ST-DDT requested review from Shinigami92 and a team April 1, 2023 19:51
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 2, 2023 11:21
@Shinigami92 Shinigami92 merged commit 3c176b2 into faker-js:next Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@munkeawtoast munkeawtoast

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@munkeawtoast @matthewmayer @ST-DDT @Shinigami92