-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(random): prevent infinite do-while #1938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1938 +/- ##
=======================================
Coverage ? 99.62%
=======================================
Files ? 2357
Lines ? 236856
Branches ? 1225
=======================================
Hits ? 235973
Misses ? 861
Partials ? 22
|
xDivisionByZerox
requested changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get a test that verifies this behavior?
Something like this?
it('fails if no data are avalible', () => {
const faker = new Faker();
faker.definitions = {};
expect(() => faker.random.word()).toThrowError();
});
xDivisionByZerox
added
needs test
More tests are needed
s: accepted
Accepted feature / Confirmed bug
labels
Mar 15, 2023
matthewmayer
previously requested changes
Mar 15, 2023
xDivisionByZerox
approved these changes
Mar 15, 2023
import-brain
approved these changes
Mar 15, 2023
ST-DDT
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: bug
Something isn't working
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from