Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): de color human #1997

Merged
merged 7 commits into from
Apr 23, 2023
Merged

feat(locale): de color human #1997

merged 7 commits into from
Apr 23, 2023

Conversation

xDivisionByZerox
Copy link
Member

Add common, human-readable colors to the german locale.

@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner March 30, 2023 16:34
@xDivisionByZerox xDivisionByZerox self-assigned this Mar 30, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team March 30, 2023 16:34
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: color Something is referring to the color module labels Mar 30, 2023
@xDivisionByZerox xDivisionByZerox changed the title locale(de): add color human feat(locale): de color human Mar 30, 2023
ST-DDT
ST-DDT previously approved these changes Mar 30, 2023
View reviewed changes
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 30, 2023
@ST-DDT ST-DDT requested a review from a team March 30, 2023 16:41
@codecov
Copy link

codecov bot commented Mar 30, 2023 •
edited
Loading

Codecov Report

Merging #1997 (1f19d78) into next (acb9cf5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 1f19d78 differs from pull request most recent head fbbd9dd. Consider uploading reports for the commit fbbd9dd to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1997      +/-   ##
==========================================
+ Coverage   99.59%   99.62%   +0.02%     
==========================================
  Files        2538     2540       +2     
  Lines      242636   242323     -313     
  Branches     1302     1301       -1     
==========================================
- Hits       241658   241403     -255     
+ Misses        951      893      -58     
  Partials       27       27
Impacted Files Coverage Δ
src/locales/de/color/human.ts 100.00% <100.00%> (ø)
src/locales/de/color/index.ts 100.00% <100.00%> (ø)
src/locales/de/index.ts 100.00% <100.00%> (ø)

... and 70 files with indirect coverage changes

matthewmayer
matthewmayer previously approved these changes Mar 31, 2023
View reviewed changes
@ST-DDT ST-DDT added the do NOT merge yet Do not merge this PR into the target branch yet label Apr 1, 2023
@ST-DDT ST-DDT dismissed their stale review April 4, 2023 20:41

See above

@xDivisionByZerox @ST-DDT
Update src/locales/de/color/human.ts
e723937 
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@ST-DDT ST-DDT requested review from matthewmayer, Shinigami92 and a team April 7, 2023 11:33
@ST-DDT ST-DDT removed the do NOT merge yet Do not merge this PR into the target branch yet label Apr 7, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) April 23, 2023 10:57
@ST-DDT ST-DDT merged commit 2675ec2 into next Apr 23, 2023
@Shinigami92 Shinigami92 deleted the locale/de/add-color branch May 1, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer Awaiting requested review from matthewmayer

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: locale Permutes locale definitions m: color Something is referring to the color module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@xDivisionByZerox @matthewmayer @ST-DDT @Shinigami92