Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): rename cz to cs_CZ #2013

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1976

@matthewmayer matthewmayer requested a review from a team April 2, 2023 16:53
@matthewmayer matthewmayer requested a review from a team as a code owner April 2, 2023 16:53
@matthewmayer matthewmayer self-assigned this Apr 2, 2023
@matthewmayer matthewmayer added c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Apr 2, 2023
@matthewmayer matthewmayer force-pushed the refactor/czech-locale branch from 992e4ef to 7e8faf3 Compare April 2, 2023 16:56
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #2013 (ece4fe5) into next (ea62046) will decrease coverage by 0.01%.
The diff coverage is 64.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2013      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.01%     
==========================================
  Files        2562     2563       +1     
  Lines      243236   243248      +12     
  Branches     1276     1280       +4     
==========================================
+ Hits       242314   242322       +8     
- Misses        896      899       +3     
- Partials       26       27       +1     
Impacted Files Coverage Δ
src/locale/cz.ts 0.00% <0.00%> (-100.00%) ⬇️
src/locales/cs_CZ/company/adjective.ts 100.00% <ø> (ø)
src/locales/cs_CZ/company/descriptor.ts 100.00% <ø> (ø)
src/locales/cs_CZ/company/index.ts 100.00% <ø> (ø)
src/locales/cs_CZ/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/cs_CZ/company/noun.ts 100.00% <ø> (ø)
src/locales/cs_CZ/company/suffix.ts 100.00% <ø> (ø)
src/locales/cs_CZ/date/index.ts 100.00% <ø> (ø)
src/locales/cs_CZ/date/month.ts 100.00% <ø> (ø)
src/locales/cs_CZ/date/weekday.ts 100.00% <ø> (ø)
... and 40 more

... and 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Apr 2, 2023
@ST-DDT ST-DDT requested review from a team April 2, 2023 21:04
@ST-DDT
Copy link
Member

ST-DDT commented Apr 3, 2023

Please fix the merge conflict.

@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Apr 3, 2023
@ST-DDT ST-DDT requested a review from a team April 4, 2023 07:25
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 4, 2023
@matthewmayer matthewmayer removed the needs rebase There is a merge conflict label Apr 4, 2023
@ST-DDT ST-DDT merged commit a95fc51 into faker-js:next Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong ISO code used for Czech locale
4 participants