feat(locale): add city names for th

[matthewmayer]

Adds city names for th. This stops fakerTH.location.city() sometimes throwing when #2004 is merged, as th had no city patterns, so fell back to en patterns, but sometimes that would select a pattern with a city_prefix, which was empty in th.

[codecov]

Codecov Report

Merging #2075 (ea3d1bb) into next (16d611f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2075   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        2536     2538    +2     
  Lines      242236   242253   +17     
  Branches     1298     1302    +4     
=======================================
+ Hits       241293   241330   +37     
+ Misses        916      896   -20     
  Partials       27       27           

Impacted Files	Coverage Δ
src/locales/th/location/city.ts	100.00% <100.00%> (ø)
src/locales/th/location/city_name.ts	100.00% <100.00%> (ø)
src/locales/th/location/index.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[ST-DDT]

This needs updating.

[matthewmayer]

Test failure seems unrelated see #2080

[ST-DDT]

Test failure seems unrelated see #2080

Yeah, one of the rare cases where a float() is an int.

[ST-DDT]

Are the city prefixes/suffixes not applicable to th in general or did you remove them because we dont need them for the current pattern?

[matthewmayer]

Are the city prefixes/suffixes not applicable to th in general or did you remove them because we dont need them for the current pattern?

Both

[ST-DDT]

If it is not applicable, then keeping the data as [] shows to the other developers that this is intentionally absent.
Also the [] does not really add big memory or source code overhead, so I think we should keep them.

[matthewmayer]

My assumption was that was only needed for definitions which have public methods. Now that citysuffix and cityprefix are no longer methods, seems like they could just be omitted for locales that don't need them?

[xDivisionByZerox]

[...] Now that citysuffix and cityprefix are no longer methods, seems like they could just be omitted for locales that don't need them?

Yes they are indeed no longer accessible via public methods, BUT if the city suffixes/prefixes simply don't exist in the th locale they should be left in. This allows us to track which data is actually missing and which are not applicable. This will become easier after #2078.

[matthewmayer]

Sure, restored