-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): cs_CZ state_abbr not applicable #2140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
labels
May 8, 2023
ST-DDT
approved these changes
May 8, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2140 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 2631 2631
Lines 245567 245563 -4
Branches 1153 1152 -1
=======================================
- Hits 244574 244571 -3
+ Misses 966 965 -1
Partials 27 27
|
xDivisionByZerox
commented
May 8, 2023
matthewmayer
approved these changes
Jun 17, 2023
import-brain
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: location
Something is referring to the location module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the locale data of
cs_CZ.location.state_abbr
to non-applicable.The previous locale file even included a comment hinting in that direction.